3 replies to this topic

[Roderic]

Hi all,

I'm just starting preparing for the CLD exam and I'd like to get some feedback on my coding style.

I think my documentation is weak, and I have some functionality issues (slides doesn't seem to work so I added a digital display I dunno what I've done wrong).I did not used tip strips for FP objects as it seems like they removed it from the exam requirements.

I found the time limit to be tight (maybe I'll get 15 extra minutes with the new format as I don't need to make the front panel)

Can you please rate my code?

Best regards,


Rodéric

Attached Files

•  Boiler Controler.zip   288.73K   100 downloads

[neil]

Taken a v quick look, some comments:

too many wire bends, you will lose marks for this. I think you should try and align things a bit more nearly. I know its quite tough in the given time, this is something you should practice as part of your normal LabVIEW coding.

local variable, marks off for these

your overall structure seems fine though, just try and improve your neatness
.
If memory serves me correctly, there used to be a penalty for not including Tip Strips and descriptions for all FP controls.
<edit> just noticed your mention of this in your post. I do not know if they are required or not.

question: why in your event handler do you use the Ctrl Ref to get Value rather than just reading the NewVal directly from the cluster provided?

Edited by neil, 28 September 2011 - 09:14 PM.

[Roderic]

Neil thanks for the input, I'll try to make it more neat, meaning I really need to code faster.

To answer your question: I don't know, this seemed to be the right thing to do as I get the value at the moment the value changes (in case I have multiple states in the FIFO), but I think your method is simpler and maybe the best way to handle this (and it's simpler/faster). thanks.

Do you think I would pass with a bit more practice or there are some major improvements needed?

Edited by Roderic, 29 September 2011 - 07:22 AM.

[neil]

I am not saying dont use the event structure, just there is no need to obtain the value from a control reference, it is available directly inside the event.

About the wire bends, I think the max you can lose is 1 point so I would not worry too much about it. I was v careful in my exam and still ended up losing that 1 point, grrr! There is not really any spare time, so you need to code the exam the way you normally code, or you will run out of time. If you are not going to take the exam soon I would recommend practicing to be a bit neater in your day job code, and then when you do get around to doing the exam it will come naturally.

If you can finish the exam with most of the features complete (and a runnable app) then yes I would think you should pass, your architecture is fine as it is. Brush up on what is required from a documentation point of view, its been a while since I did mine and I think they changes the requirements.