Jump to content

Map, implemented with classes, for 8.5


Recommended Posts

QUOTE (Aristos Queue @ Apr 9 2008, 11:40 AM)

QUOTE

At the end of the day, I don't know why NI won't prioritize adding a nice associative array function to the Queue and Notifier palette.
It might be because I've never heard of this idea before. What exactly would this be?

I think that Jason's referring to the possibility of having a new AssociativeArray by-reference sibling to the Queues and Notifiers types+functions that enjoys the same sort of edit-time type propogation (e.g., Queue and Notifier references contain the type of Queue/Notifier element data, which causes the Queue and Notifier functions to adapt to these types). Just as Queue and Notifier element/data types propogate to the primatives, it would be nice if the key and value types of an AssociativeArray could propogate to primitive Get/Set/Delete/etc. functions. Yes, we can do it with OOP and inheritance + dynamic methods, but it would be nice if AssociativeArray could be a LabVIEW primitive type+functions.

Link to comment
  • Replies 89
  • Created
  • Last Reply

Top Posters In This Topic

QUOTE (Aristos Queue @ Apr 9 2008, 11:40 AM)

OK.

QUOTE (Aristos Queue @ Apr 9 2008, 11:40 AM)

Oh, I'm pretty sure this solution will beat all others someday. From the theory side, it'll blow just about everything else out of the water. We're still in unexplored territory with this, and there may very well be some stupid implementation detail that is getting in the way. In school, I was once debugging a program that should've been blazing fast, only to find that in my delirium I had written code that instead of calculating a constant and storing it was recalculating a constant every time I needed it. It wasn't even relevant to the algorithm, just happened to be a needed constant. There is almost certainly something like that somewhere in the LVClass code. I'll grant that it may take a few years to iron out, and in the meantime, enjoy the acceleration of the variants.

Well the tree rebalance requires a few conversions between generic map nodes and branch nodes, and there is a buffer allocation at each of those. As far as I can tell that's killing performance, but I don't know enough about the inheritance implementation to know whether that conversion could be done without a copy. There are other branch class subvis that also show buffer allocation on bother input and output, and I don't know why, since a dynamic dispatch terminal is used on both input and output and the wire does not branch.

QUOTE (Aristos Queue @ Apr 9 2008, 11:40 AM)

It might be because I've never heard of this idea before. What exactly would this be?

Well I know various people have asked for a hash table. I asked Brian Powell for this at the last NI Week and he basically said the idea of wrapping up the C++ STL (which includes maps) had been batted around for a while.

I realized we could just wrap up STL's hash_map ourselves, which we are working on (I doubt I will be able to release it though, sorry). When thinking about a LabVIEW API, I am trying to make it as close to the Queue and Notifier API as possible, since those work pretty well, and LabVIEW users are accustomed to how they work, with respect to named versus unnamed references, and the timeouts, and the release or destroy . Whereas queues are FIFO access to a by-reference data collection, the hash map could be associative (named) access to a by-reference data collection. One feature that I am going to add is that you can request a lock on an item so that it can be modified on a block diagram and reinserted into the map without danger of a race condition. If you want more input, maybe we should start a new thread about the design, but I thought the need has been evident for a while. (given the amount of time and energy which has been put in by various people inside and outside of NI).

Anyway, if you did this in LabVIEW with polymorphic (strictly-typed) functions, it would be way better than what I am going to make. [this is exactly what Jim Kring just wrote. +1]

Link to comment
QUOTE (jdunham @ Apr 9 2008, 05:05 PM)
Anyway, if you did this in LabVIEW with polymorphic (strictly-typed) functions, it would be way better than what I am going to make. [this is exactly what Jim Kring just wrote. +1]
Oh. That's exactly what is posted to ni.com/labs. It uses the XNode polymorphism to implement the associative array. :-)
Link to comment
QUOTE (jdunham @ Apr 10 2008, 03:56 AM)
The Xnode version is the pink line.
Thank you for including this one in your test results. I've fielded your posts out to half a dozen NI engineers to evaluate the results and see if there are any obvious slowdowns that can be patched in time for the next release. We'll see what happens.
Link to comment

QUOTE (Aristos Queue @ Apr 10 2008, 09:31 PM)

Thank you for including this one in your test results. I've fielded your posts out to half a dozen NI engineers to evaluate the results and see if there are any obvious slowdowns that can be patched in time for the next release. We'll see what happens.

I found there are some obvious slowdowns can be fixed easily in it. I tried to change some of its code yesterday, and the performance improve is huge. The result is it runs faster than all the other approaches.

The original purpose of the LabVIEW Generic Container is just to investigate a way of providing common data structures in LabVIEW. We didn't put much effort on its performance.

Hopefully, we will release a new version of it with better performance in a couple of months.

Link to comment

QUOTE (Q^Q @ Apr 11 2008, 09:42 AM)

I found there are some obvious slowdowns can be fixed easily in it. I tried to change some of its code yesterday, and the performance improve is huge. The result is it runs faster than all the other approaches.

The original purpose of the LabVIEW Generic Container is just to investigate a way of providing common data structures in LabVIEW. We didn't put much effort on its performance.

Hopefully, we will release a new version of it with better performance in a couple of months.

Well that's great news. I don't know what it would take to get into a real LabVIEW release, but that would be welcome. If the tool can never graduate from NI Labs in to NI LabVIEW (shipping version), it really isn't much help. Did you find/fix the problem where deletes got into an infinite loop?

If you wan't some extra homework, it would be extremely useful to be able to independently lock items read from the map so that a save read-modify-write cycle could be performed on a LabVIEW diagram. This can be done with LabIEW semaphores, but then you are adding an O(n) performance hit to get the semaphore.

Thanks for your efforts Q^Q; it's very encouraging.

Link to comment

QUOTE (jdunham @ Apr 12 2008, 01:09 AM)

Well that's great news. I don't know what it would take to get into a real LabVIEW release, but that would be welcome. If the tool can never graduate from NI Labs in to NI LabVIEW (shipping version), it really isn't much help. Did you find/fix the problem where deletes got into an infinite loop?

If you wan't some extra homework, it would be extremely useful to be able to independently lock items read from the map so that a save read-modify-write cycle could be performed on a LabVIEW diagram. This can be done with LabIEW semaphores, but then you are adding an O(n) performance hit to get the semaphore.

Thanks for your efforts Q^Q; it's very encouraging.

I have some urgent job to do in the two weeks. So, I just made a quick test on the XNode Map code. I think I've found the problems in the Map code. It will be fixed once I finish my current work.

The XNode Map, unlike the lvclass one, has to manage the memory of all elements data itself. So, its code is much more complicated. (Could have more bugs.)

NI is investigating the best way of providing common used data structures in LabVIEW. I'm not sure when it will make the final decision. The final app could be the XNode approach or the lvcalss approach, or another approach that includes both advantages of the former two.

Thanks a lot for benchmarking all of them!

Link to comment
  • 3 months later...
  • 1 year later...
  • 1 year later...

Here's the original attachment:

Map_Class.zip

It was deleted when LAVA got wiped out in early 2009.

Aristos,

I know this post is kind of old. So maybe things have changed, do you know if variants are still the best performers for mapping? Also, I couldn't find the XNode implementation @ NI Labs and all the links in this post are pointing to different places, so it is hard to find. Is still there? or has it made it into shipping LabVIEW?

Thanks,

Fab

Link to comment
  • 3 years later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.