pratima Posted February 13, 2011 Report Share Posted February 13, 2011 Dear to All, Next week I am going to appear for CLD examination.I am developing some codes as given example on NI website.Please give me the feedback after looking at my code.Explain each and every thing what should i do or dont. Topic Description Code Problem-Sprinkler Controller Simulation Labview Version-2010 Sprinkler Controller Application.zip Pratima Quote Link to comment
Kip_K Posted February 28, 2011 Report Share Posted February 28, 2011 Dear to All, Next week I am going to appear for CLD examination.I am developing some codes as given example on NI website.Please give me the feedback after looking at my code.Explain each and every thing what should i do or dont. Topic Description Code Problem-Sprinkler Controller Simulation Labview Version-2010 Sprinkler Controller Application.zip Pratima Looks good. I could suggest a few things. Several spelling mistakes on things. While not a functional problem, it can look bad on a front panel to a customer. In the RunningZone.vi, there is an input to an error shift register that isn't connected properly. Can be a bear to locate the error source when hidden like this. You created a state machine within a do-while loop. Adding a time delay will reduce resource loading, as this loop will run a lot. Or, switch to a producer-consumer loop. It appears that some of the files have had their name corrected from "Sprikler" to "Sprinkler", but a few files were not, and the project file is not up to date. For an exam perspective, you'll do fine. Regards, Kip Quote Link to comment
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.