JasonXCX Posted May 30, 2008 Report Share Posted May 30, 2008 Some time ago somepeople was looking for a Low frequency generator. I am trying to learn LabView with good books and my computer , I draw this VI as an exercice. It run but I am sure that , it is not the best VI ever made. I am looking for your improuvements. Jason Quote Link to comment
orko Posted May 30, 2008 Report Share Posted May 30, 2008 QUOTE (JasonXCX @ May 29 2008, 05:46 AM) Some time ago somepeople was looking for a Low frequency generator. I am trying to learn LabView with good books and my computer , I draw this VI as an exercice. It run but I am sure that , it is not the best VI ever made. I am looking for your improuvements. Jason I can't read French, but this looks like a good first attempt. There are some things that pop out at me: 1) The front panel is a little skewed. If you are going to have anything resizing with the panel, then you may want to have everything resize. I personally like to not have anything resize, and not show the scroll bars so that the FP is fixed...but that's a preference thing. 2) The BD is for the most part fairly clean. Good job! Even though I can't read the labels, I can understand the flow and logic behind the code. 3) You may wish to take the main code and place it into a subVI, with your parameters as inputs and waveform/results as outputs. This will clean it up a bit more. 4) Are you sure on your math to get X in radians for the input of the Sine function? I'm seeing (Phase/(360*Freq))*(Freq*2pi) for the first iteration of the loop. It's early yet in Seattle, so I may just need a second cup of coffee before I understand what you're doing here... 5) Alright, I need to know... what does this mean in English? http://lavag.org/old_files/monthly_05_2008/post-3266-1212090586.png' target="_blank"> My wife's name is very close to this: Carrie Sines... so I'm dying to know Quote Link to comment
Yair Posted May 30, 2008 Report Share Posted May 30, 2008 QUOTE (orko @ May 29 2008, 10:55 PM) 5) Alright, I need to know... what does this mean in English? http://lavag.org/old_files/monthly_05_2008/post-3266-1212090586.png' target="_blank"> I don't speak French either, but I know that sinus is a sine and Google says that carré is square, so I assume it means "square sine wave". I'm not sure whether your wife will appreciate that or not... Quote Link to comment
PaulG. Posted May 30, 2008 Report Share Posted May 30, 2008 QUOTE (Yen @ May 29 2008, 04:31 PM) ... I assume it means "square sine wave". There is no such thing as a "square sine wave". It's sinusoidal or it non-sinusoidal. It can't be both. Quote Link to comment
Ton Plomp Posted May 31, 2008 Report Share Posted May 31, 2008 QUOTE (orko @ May 29 2008, 08:55 PM) My wife's name is very close to this: Carrie Sines... so I'm dying to know So Orko got a square wife QUOTE (PaulG. @ May 29 2008, 10:14 PM) There is no such thing as a "square sine wave". It's sinusoidal or it non-sinusoidal. It can't be both. I'm not sure but I remember from high-school that there is a sinus 'function' where the signal is flat during the first n degrees, maybe that's it? EDIT: It's a square wave Ton Quote Link to comment
Yair Posted May 31, 2008 Report Share Posted May 31, 2008 QUOTE (PaulG. @ May 30 2008, 12:14 AM) There is no such thing as a "square sine wave". It's sinusoidal or it non-sinusoidal. It can't be both. I figured as much, but didn't feel like searching to make sure this isn't something that does exist and which I don't know about. For example, http://en.wikipedia.org/wiki/User:Kieff/Square_sine_and_cosine_functions' rel='nofollow' target="_blank">here's someone who thinks such a thing should exist. Anyway, from looking at the code it's clear, as Ton said, that it's a selection between a sine wave and a square wave. Quote Link to comment
orko Posted June 1, 2008 Report Share Posted June 1, 2008 QUOTE (tcplomp @ May 29 2008, 09:22 PM) So Orko got a square wife Hey, they said it was http://www.youtube.com/watch?v=F_byVtHrGEM' rel='nofollow' target="_blank">Hip to Be Square! Quote Link to comment
JasonXCX Posted June 1, 2008 Author Report Share Posted June 1, 2008 Thank you for your remarks . I can't read French, but this looks like a good first attempt. There are some things that pop out at me: 1) The front panel is a little skewed. If you are going to have anything resizing with the panel, then you may want to have everything resize. I personally like to not have anything resize, and not show the scroll bars so that the FP is fixed...but that's a preference thing. I will try this . The front panel is green because when I was at school we had some very old scopes ( oscilloscopes ) with the front panel green . The BD is for the most part fairly clean. Good job! Even though I can't read the labels, I can understand the flow and logic behind the code. You may wish to take the main code and place it into a subVI, with your parameters as inputs and waveform/results as outputs. This will clean it up a bit more. Yes it is the next step. Are you sure on your math to get X in radians for the input of the Sine function? I'm seeing (Phase/(360*Freq))*(Freq*2pi) for the first iteration of the loop. It's early yet in Seattle, so I may just need a second cup of coffee before I understand what you're doing here... It is the phase adjustments 5) Alright, I need to know... what does this mean in English? It the choice between sine ( sinus ) function and square ( carré ) function 010101 My wife's name is very close to this: Carrie Sines... so I'm dying to know Best regards to your wife . I will translate the Vi in english . Quote Link to comment
zhpipo16 Posted June 5, 2008 Report Share Posted June 5, 2008 QUOTE (JasonXCX @ May 31 2008, 09:15 AM) Thank you for your remarks . I can't read French, but this looks like a good first attempt. There are some things that pop out at me: 1) The front panel is a little skewed. If you are going to have anything resizing with the panel, then you may want to have everything resize. I personally like to not have anything resize, and not show the scroll bars so that the FP is fixed...but that's a preference thing. I will try this . The front panel is green because when I was at school we had some very old scopes ( oscilloscopes ) with the front panel green . hello every body i speak french very well and that mean (sin signal or square signal) you cab chose with this key (t/f) it's clear? The BD is for the most part fairly clean. Good job! Even though I can't read the labels, I can understand the flow and logic behind the code. You may wish to take the main code and place it into a subVI, with your parameters as inputs and waveform/results as outputs. This will clean it up a bit more. Yes it is the next step. Are you sure on your math to get X in radians for the input of the Sine function? I'm seeing (Phase/(360*Freq))*(Freq*2pi) for the first iteration of the loop. It's early yet in Seattle, so I may just need a second cup of coffee before I understand what you're doing here... It is the phase adjustments 5) Alright, I need to know... what does this mean in English? http://lavag.org/old_files/monthly_05_2008/post-3266-1212090586.png' target="_blank"> It the choice between sine ( sinus ) function and square ( carré ) function 010101 My wife's name is very close to this: Carrie Sines... so I'm dying to know Best regards to your wife . I will translate the Vi in english . hello i speak french very well and that mean( chose sine or squar signale with this key (true/false) it is for generating a sine or square signal) Quote Link to comment
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.