Mark Smith Posted January 20, 2009 Report Share Posted January 20, 2009 Download File:post-1322-1232389172.zip Anyone have time to take a look at my Security System implementation (the sample CLD app)? I'm taking the CLD Thursday and would appreciate any comments. Thanks, Mark Quote Link to comment
LAVA 1.0 Content Posted January 20, 2009 Report Share Posted January 20, 2009 Impressive and advanced solution with reentrant VIs. (points for that). Easy comment: No documentation on the BD of the GUI VI. (esp. in the event structure) No on-line help on the led-status of the GUI VI. Intermediate comment: Mix-up of system and labview GUI elements (BD color is dialog the rest is native LabVIEW) Advanced critique: I would use a VI-reference to load the reentrant VIs: (As you can see the BD of this VI has no documentation.) Use the auto-clean up tool for simple VIs, your reentrant loader had a lot of white space, auto-cleanup eases things out. Good-luck, with such a solution you have to pass. Ton Quote Link to comment
Mark Smith Posted January 20, 2009 Author Report Share Posted January 20, 2009 QUOTE (Ton @ Jan 19 2009, 12:08 PM) Impressive and advanced solution with reentrant VIs. (points for that).Easy comment: No documentation on the BD of the GUI VI. (esp. in the event structure) No on-line help on the led-status of the GUI VI. I just ran out of time! So that is exactly what I would have had to submit and I guess I would have been dinged :thumbdown: QUOTE (Ton @ Jan 19 2009, 12:08 PM) Intermediate comment: Mix-up of system and labview GUI elements (BD color is dialog the rest is native LabVIEW) I often make the User Interface VIs the dialog color (even though they may not be dialogs) because 1) It looks more "native" to windows 2) And it helps me immediately identify the FPs the end users will see Is this considered poor style by the LV community? QUOTE (Ton @ Jan 19 2009, 12:08 PM) Advanced critique: I would use a VI-reference to load the reentrant VIs: I like that - it does seem cleaner - I'll have to remember this QUOTE (Ton @ Jan 19 2009, 12:08 PM) (As you can see the BD of this VI has no documentation.) Use the auto-clean up tool for simple VIs, your reentrant loader had a lot of white space, auto-cleanup eases things out. Good-luck, with such a solution you have to pass. Ton Thanks for the feedback - I've been doing LabVIEW a long time but one can never do too much prep for an exam. Mark Quote Link to comment
gleichman Posted January 20, 2009 Report Share Posted January 20, 2009 How long did this take you? My advice is keep it simple and get it done. Clean code with good documentation. Clever will waste your time and leave you with an incomplete project that isn't fully documented. One quick comment, the "Standard State Machine.vi" has a three deep case structure in the "Update" case. Use the "select" function in the comparison palellete for a cleaner and more readable vi. Quote Link to comment
jcarmody Posted January 20, 2009 Report Share Posted January 20, 2009 QUOTE (gleichman @ Jan 19 2009, 03:09 PM) One quick comment, the "Standard State Machine.vi" has a three deep case structure in the "Update" case. Use the "select" function in the comparison palellete for a cleaner and more readable vi. I was going to say that! I always get beaten to the punch... Also, and I don't know if it matters to the judges, but it's cleaner to label your wires with a System label. Good job! /Jim Quote Link to comment
Mark Smith Posted January 20, 2009 Author Report Share Posted January 20, 2009 QUOTE (gleichman @ Jan 19 2009, 01:09 PM) How long did this take you? My advice is keep it simple and get it done. Clean code with good documentation. Clever will waste your time and leave you with an incomplete project that isn't fully documented.One quick comment, the "Standard State Machine.vi" has a three deep case structure in the "Update" case. Use the "select" function in the comparison palellete for a cleaner and more readable vi. I spent about 3.5 hours on the project (4 hours on the clock but with interruptions) - There was certainly no intention on my part to be clever - I've just spent a lot of time lately with scalable architectures using reentrancy so that's the first architecture that came to mind that I was sure I could code start to finish. What took longer than I thought was re-acquainting myself with the LabVIEW FileI/O VIs to create the logger part of the problem . I just haven't used them in a while and they've changed! QUOTE (jcarmody @ Jan 19 2009, 01:39 PM) I was going to say that! I always get beaten to the punch... Also, and I don't know if it matters to the judges, but it's cleaner to label your wires with a System label. Good job! /Jim Thanks to both for this tip - it is a lot easier to read. And as far as system labels, I had to go google that to find out what it was (took me to the LAVA WIKI!) Mark Quote Link to comment
TobyD Posted January 20, 2009 Report Share Posted January 20, 2009 Good comments so far. One minor nit-pick...I noticed that your log file logs zones 0-5 but the zones are labeled 1-6. That's an interesting architecture with the multiple reentrant state machines. :thumbup: Quote Link to comment
Michael Aivaliotis Posted January 20, 2009 Report Share Posted January 20, 2009 Regardless of your fancy footwork, I would fail you because your app is dead in the water right from the start. I can't even run it because you've hardcoded a path to a VI: If your app doesn't work out of the box, it's made of FAIL. It's like going to an audition on American Idol and you forget the lyrics to the song. Quote Link to comment
Mark Smith Posted January 20, 2009 Author Report Share Posted January 20, 2009 QUOTE (Michael_Aivaliotis @ Jan 19 2009, 03:06 PM) Regardless of your fancy footwork, I would fail you because your app is dead in the water right from the start. I can't even run it because you've hardcoded a path to a VI: http://lavag.org/old_files/monthly_01_2009/post-2-1232402565.png' target="_blank"> If your app doesn't work out of the box, it's made of FAIL. It's like going to an audition on American Idol and you forget the lyrics to the song. Thanks for the observation - that's the stuff I need to hear Mark Quote Link to comment
Mark Smith Posted February 6, 2009 Author Report Share Posted February 6, 2009 I passed my CLD Lucky for me, Michael didn't get to grade my exam - or maybe his advice kept me from making silly mistakes! Thanks to all for the feedback and help - LAVA is a great community. Mark Quote Link to comment
Mark Yedinak Posted February 6, 2009 Report Share Posted February 6, 2009 QUOTE (mesmith @ Feb 5 2009, 03:50 PM) I passed my CLD Lucky for me, Michael didn't get to grade my exam - or maybe his advice kept me from making silly mistakes! Thanks to all for the feedback and help - LAVA is a great community. Mark Congrats! I took my exam at the end of last year and was notified last month that I passed. Now onto the CLA exam. Quote Link to comment
TobyD Posted February 6, 2009 Report Share Posted February 6, 2009 QUOTE (mesmith @ Feb 5 2009, 01:50 PM) I passed my CLD QUOTE (Mark Yedinak @ Feb 5 2009, 02:04 PM) Congrats! I took my exam at the end of last year and was notified last month that I passed. Congratulations to you both! Quote Link to comment
Michael Aivaliotis Posted February 6, 2009 Report Share Posted February 6, 2009 QUOTE (mesmith @ Feb 5 2009, 01:50 PM) I passed my CLD Lucky for me, Michael didn't get to grade my exam - or maybe his advice kept me from making silly mistakes! Thanks to all for the feedback and help - LAVA is a great community. Mark Big congrats to you! And thank you for letting us review your sample program. I think it's good practice to let other LAVA members (or others in general) review your work. This is one of the points mentioned in http://labviewartisan.blogspot.com/2009/01/labview-certification-preparing-for-cld.html' rel='nofollow' target="_blank">Darren's blog post. Quote Link to comment
Darren Posted February 7, 2009 Report Share Posted February 7, 2009 QUOTE (Michael Aivaliotis @ Feb 5 2009, 06:37 PM) This is one of the points mentioned in http://labviewartisan.blogspot.com/2009/01/labview-certification-preparing-for-cld.html' rel='nofollow' target="_blank">Darren's blog post. Thanks for the shout-out, Mike. And congrats on passing the CLD, Mark! I plan on posting an article on my blog soon about preparing for the CLA...stay tuned! -D Quote Link to comment
GSR Posted February 7, 2009 Report Share Posted February 7, 2009 QUOTE (jcarmody @ Jan 19 2009, 09:39 PM) Also, and I don't know if it matters to the judges, but it's cleaner to label your wires with a System label. http://lavag.org/old_files/monthly_01_2009/post-7534-1232397515.gif' target="_blank"> /Jim Could you please teach me how to label the wires? I cannot find this function in LabVIEW; and I always do the system label only. Thanks Quote Link to comment
jcarmody Posted February 7, 2009 Report Share Posted February 7, 2009 QUOTE (zmarcoz @ Feb 6 2009, 08:54 AM) Could you please teach me how to label the wires? I cannot find this function in LabVIEW; and I always do the system label only. Thanks I get the system label from here: (someone else may get it from the Block Diagram, but I can't find it.) The System Label adapts to the background color. Your label wasn't like that. http://lavag.org/old_files/monthly_02_2009/post-7534-1233943593.jpg' target="_blank"> Quote Link to comment
Michael Aivaliotis Posted February 7, 2009 Report Share Posted February 7, 2009 QUOTE (zmarcoz @ Feb 6 2009, 05:54 AM) Could you please teach me how to label the wires? I cannot find this function in LabVIEW; and I always do the system label only. Thanks I suggest you read through the http://wiki.lavag.org/Tips_and_tricks' rel='nofollow' style="background: url(http://wiki.lavag.org/skins/monobook/external.png) center right no-repeat; padding-right: 13px; style="border-bottom: 1px dotted rgb(51, 102, 187); cursor:pointer; text-decoration:none;" class="wiki" alt="Link to LabVIEW Wiki Article: Tips_and_tricks" title="Link to LabVIEW Wiki Article: Tips_and_tricks">Tips_and_tricks Wiki page. This was mentioned in there. Quote Link to comment
GSR Posted February 8, 2009 Report Share Posted February 8, 2009 QUOTE (jcarmody @ Feb 6 2009, 07:08 PM) I get the system label from here: (someone else may get it from the Block Diagram, but I can't find it.) The System Label adapts to the background color. Your label wasn't like that. http://lavag.org/old_files/monthly_02_2009/post-7534-1233943593.jpg' target="_blank"> I see! thanks! I misunderstood what system label was. I thought system label was using edit text function to put text on the block diagram. Now I understand that there is a system label function to label the wires. thanks again Quote Link to comment
bsvingen Posted February 9, 2009 Report Share Posted February 9, 2009 I mostly find labelling wires to be confusing and difficult to work with. They don't really show any information that is not already there in most cases, unless you have really long wires. They are free labels, meaning the automatic wiring tools will route wires around them. All in all, I have stopped using them entirely. An alternative method is to use the "Description and tip..." when rightklicking on the wire. Open the online help, Ctrl-h, and now you see the "label" or description when your mouse is hoovering above the wire. An added bonus is that wire branches will also have the same description. This is a much better solution IMO. Quote Link to comment
Darren Posted February 10, 2009 Report Share Posted February 10, 2009 QUOTE (Darren @ Feb 5 2009, 09:37 PM) I plan on posting an article on my blog soon about preparing for the CLA...stay tuned! I just finished the article on my blog about preparing for the CLA. See http://labviewartisan.blogspot.com/2009/02/labview-certification-preparing-for-cla.html' rel='nofollow' target="_blank">here. -D Quote Link to comment
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.