Jump to content
Wouter

String To Character Array (String Package)

Recommended Posts

I think it should be added. It can be added easily to the current code. Just make the 1 constant a input variable and set 1 as a default.

post-10325-0-53415300-1316309682.png

I know it is a small change, but I don't think that is a good enough reason to justify a(ny) feature.

  • Like 2

Share this post


Link to post
Share on other sites

I would also like to conclude this review with the original (simple) code as well.

As Darin pointed out, there are a few behaviors to consider.

Would this 'chunking' feature be better suited to a new function?

If so, let me know, and it could be reviewed in the future.

Cheers

-JG

Share this post


Link to post
Share on other sites

I think the fundamental functionality of this VI (split into single elements) is the way it should stay. Once the data is broken up, it's relatively trivial to reassemble it into desired chunk sizes.

Share this post


Link to post
Share on other sites

Just so we are all on the same page, the change is not as small as advertised (not that it is that big a deal).

Yes, it was not a big deal to implement the multi-character functionality (that is what I meant).

I think you need to use sign( R ) like this:

I did it similar to this when I coded it, but I like the above better.

handling the case where the data size is not commensurate with the chunk size (padding or clipping). The offset must be multiplied by the chunk size as well.

This is the part that will generate some discussion on how to handle it.

I have gone ahead and created a separate thread for a Chunking VI so please continue this discussion there (I also posted some code to get the above mentioned functionality).

I am going to go ahead and close this review in a couple of days.

OpenG will be using the original String To Character Array function (note the name change) as below:

post-10325-0-53415300-1316309682.png

post-10325-0-36662500-1316309681.png

  • Like 1

Share this post


Link to post
Share on other sites

This review is now closed - thanks to Wouter for the original contribution and thanks everyone for their input.

Significant contributions will appear in the copyright of the released version.

Cheers!

Share this post


Link to post
Share on other sites
Guest
This topic is now closed to further replies.

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.