closed review Filter Error Codes (Error Package)

[jgcode]

  On 10/11/2011 at 5:25 PM, Wouter said:

Maybe make the icon just as large as the normal clear icon...

But that goes against the reason for having a small compact VI i the first place

I am leaning towards this one.

Anyone got any comments on the VIs Jim posted? Can it be enhanced?

I am thinking that this satisfies the requirements of this review and that it should be used as is.

[GregSands]

  On 10/12/2011 at 12:13 AM, jgcode said:

But that goes against the reason for having a small compact VI i the first place

I am leaning towards this one.

Is the gap between the small icon and the wires intentional? It does visually indicate that errors are cleared, but at the same time looks "wrong".

[jgcode]

  On 10/12/2011 at 8:08 PM, GregSands said:

Is the gap between the small icon and the wires intentional? It does visually indicate that errors are cleared, but at the same time looks "wrong".

No, it is not.

It is talked about in the above posts tho, and we tried to minimize it.

[Wouter]

  On 10/12/2011 at 12:13 AM, jgcode said:

But that goes against the reason for having a small compact VI i the first place

I never said that I was in favour for the small compact VI

But anyway I think I would rather like to see the icon stretched out a little then having the little gabs.

[Francois Normandin]

How about this?

[asbo]

Crafty! I approve.

[Wouter]

[jgcode]

  On 10/13/2011 at 6:33 PM, François Normandin said:

How about this?

  On 10/13/2011 at 6:53 PM, asbo said:

Crafty! I approve.

  On 10/14/2011 at 1:16 PM, Wouter said:

Really? I posted that CP a few posts up and didn't get anywhere near the response for François! ...lol:

  On 10/10/2011 at 4:25 AM, jgcode said:

Yer, that was my though too from the initial CP I posted:

Or we could leave it out (no Upstream Error as per the example you posted)?

I am happy with that CP too. I have all the information I require. I will move this review to pending and close it in a few days.

Cheers

-JG

[Francois Normandin]

I think it's not about the connector pane, but rather the small "ears" I added to the icon

[jgcode]

  On 10/15/2011 at 3:47 PM, François Normandin said:

I think it's not about the connector pane, but rather the small "ears" I added to the icon

Ah-hah! (Sorry, completely missed that when I looked at it!)

In that case I say "brilliant" too.

[Yair]

I'm with Wouter on this - just make the icon a bit wider. If you use François's trick, you will probably have problems with matching some of the wires, because they have a specific pattern and you would need to move the VI a couple of pixels this or that way to match it.

Here's a very quick example:

I think that this isn't too big and could probably be made better with a few minutes of polishing.

[Mellroth]

  On 10/12/2011 at 12:13 AM, jgcode said:

Anyone got any comments on the VIs Jim posted? Can it be enhanced?

I would move the Merge Error inside the Error case.

If "error in" doesn't contain any error the output should be the "upstream error", i.e. no need to merge.

/J

[jgcode]

Thanks everyone for their input - all non-functional comments and suggestions have been reviewed with respect to updating the code Jim posted.

This OpenG Review is now closed. Please start a new thread to discuss new changes to this VI. Please PM me if there are any issues with this thread.